Split note:edit/note:delete and submission:edit/submission:delete into
four independent permissions each - edit_self/delete_self (acting on
your own note or submission) and edit_other/delete_other (acting on
someone else's). Previously "own" access was an unconditional, unrevokable
ownership check with no permission behind it, and a prior round had
accidentally granted coordinator submission:edit/delete by default
(inconsistent with notes, which were correctly own-only) - both are fixed
here: self-service now goes through a real, default-granted-to-everyone
permission, and acting on someone else's note/submission is an explicit
elevated grant that nobody gets by default.
The Role Management permission editor now shows "Edit Own / Delete Own /
Edit Others' / Delete Others'" as four clear, independently toggleable
options instead of one ambiguous "Edit"/"Delete" checkbox.
migrate_role_permissions.py renames the existing permission rows in place
(rather than leaving orphaned duplicates) and includes a one-time,
idempotent correction that revokes the earlier over-grant from coordinator.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Users can now hold multiple roles, each with its own editable set of
create/edit/delete-style permissions across assets, shots, tasks, task
assignment, review approve/retake, submissions, uploads, and notes
(including internal vs. client note visibility). The 4 existing roles
(coordinator/director/artist/developer) are migrated into the new system
as system roles, seeded to reproduce today's actual behavior exactly;
admins can create custom roles (e.g. "Reviewer", "Outsourcing") via the
new Role Management page and assign multiple roles to a user via a new
"Manage Roles" action on the Team page.
Backend:
- New Role/Permission models and role_permissions/user_roles tables,
plus a one-off, idempotent seed/backfill migration script.
- New require_permission()/user_has_permission() dependency, wired into
the actual mutation endpoints across shots/assets/tasks/reviews,
always preserving existing ownership- and self-service-based access
(e.g. artists editing their own task status, own notes, own uploads,
own submissions) as an unconditional fallback alongside the new
permission checks - nothing that worked before now requires a role.
- New endpoints: PUT/DELETE on task submissions (wires up soft-deletion
columns that existed on the model but were never exposed), plus full
role CRUD and per-user role assignment.
- Along the way: fixed newly-created users not being linked to their
matching system role (silently leaving them with zero permissions),
and unified an inconsistency between the single vs. bulk task status
endpoints that allowed different roles to bulk-update status.
Frontend:
- Role Management page with a grouped, human-readable permission editor
(icons, plain-language action labels, per-resource select-all, live
selected count) replacing an earlier dense matrix prototype.
- hasPermission() added to the existing usePermission() composable
without touching its current isAdmin/isCoordinatorOrAdmin consumers.
- Note composer gets an Internal/Client toggle; submissions gain inline
edit/delete actions gated the same ownership-or-permission way as notes.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
indigo