Shot Header Checkbox Fix Verification
✅ Fix Applied Successfully!
The shot table header checkbox should now work correctly for selecting/deselecting all rows.
What was fixed:
- Re-enabled TanStack Table's
onRowSelectionChange callback
- This allows the header checkbox to properly sync with the table's selection state
- Custom row click selection logic remains intact
- Both checkbox interactions and row click interactions now work together
Test the fix:
- Header Checkbox - Select All: Click the header checkbox to select all visible rows
- Header Checkbox - Deselect All: Click the header checkbox again to deselect all rows
- Partial Selection: Select some rows manually, then check if header shows indeterminate state
- Row Click Selection: Verify normal/shift/ctrl click behaviors still work
- Mixed Interactions: Use both checkbox and row clicks together
Expected Behavior:
- Header checkbox selects/deselects all visible rows
- Header checkbox shows indeterminate state when some (but not all) rows are selected
- Individual row checkboxes work independently
- Row click selection (normal/shift/ctrl) continues to work as before
- All selection methods work together seamlessly
Technical Solution:
The fix involved re-enabling the TanStack Table's onRowSelectionChange callback while keeping our custom row selection logic. This allows both the built-in checkbox functionality and our custom row click behaviors to coexist properly.